Messages in this thread | | | Date | Sun, 4 May 2008 16:13:18 +0800 | From | "Dave Young" <> | Subject | Re: [PATCH -mm] __ratelimit rewrite |
| |
On Sun, May 4, 2008 at 3:54 PM, David Miller <davem@davemloft.net> wrote: > From: Dave Young <hidave.darkstar@gmail.com> > Date: Sun, 4 May 2008 15:07:38 +0800 > > Hi Dave, > > > > @@ -76,8 +76,8 @@ extern void warn_on_slowpath(const char > > unlikely(__ret_warn_once); \ > > }) > > > > -#define WARN_ON_SECS(condition, state, secs) \ > > - WARN_ON((condition) && __ratelimit(state)) > > +#define WARN_ON_RATELIMIT(condition, state) \ > > + WARN_ON((condition) && __ratelimit(state)); > > > > #ifdef CONFIG_SMP > > # define WARN_ON_SMP(x) WARN_ON(x) > > Are you sure you want that new semicolon there?
David, thanks for your review. Will fix.
> > if (foo) > WARN_ON_RATELIMIT(...); > else > > will result in a compile error. >
| |