Messages in this thread | | | Date | Sun, 04 May 2008 00:54:33 -0700 (PDT) | Subject | Re: [PATCH -mm] __ratelimit rewrite | From | David Miller <> |
| |
From: Dave Young <hidave.darkstar@gmail.com> Date: Sun, 4 May 2008 15:07:38 +0800
Hi Dave,
> @@ -76,8 +76,8 @@ extern void warn_on_slowpath(const char > unlikely(__ret_warn_once); \ > }) > > -#define WARN_ON_SECS(condition, state, secs) \ > - WARN_ON((condition) && __ratelimit(state)) > +#define WARN_ON_RATELIMIT(condition, state) \ > + WARN_ON((condition) && __ratelimit(state)); > > #ifdef CONFIG_SMP > # define WARN_ON_SMP(x) WARN_ON(x)
Are you sure you want that new semicolon there?
if (foo) WARN_ON_RATELIMIT(...); else
will result in a compile error.
| |