Messages in this thread | | | Date | Sun, 04 May 2008 08:22:42 -0700 | From | Hiroshi Shimamoto <> | Subject | Re: [PATCH] x86_32: move do_nmi() to nmi_32.c |
| |
Hiroshi Shimamoto wrote: > Ingo Molnar wrote: >> * Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> wrote: >> >>> From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> >>> >>> on x86_64 do_nmi() is in nmi_64.c. >> this patch caused build failure on x86.git+sched-devel.git: >> >> arch/x86/kernel/built-in.o: In function `nmi_stack_correct': >> arch/x86/kernel/entry_32.S:(.kprobes.text+0x117): undefined reference to `do_nmi' >> arch/x86/kernel/built-in.o: In function `nmi_espfix_stack': >> arch/x86/kernel/entry_32.S:(.kprobes.text+0x1c3): undefined reference to `do_nmi' >> arch/x86/kernel/built-in.o: In function `alternative_instructions': >> : undefined reference to `stop_nmi' >> arch/x86/kernel/built-in.o: In function `alternative_instructions': >> : undefined reference to `restart_nmi' >> >> with this config: >> >> http://redhat.com/~mingo/misc/config-Sun_May__4_11_25_21_CEST_2008.bad > > Oops, I've missed something. > > Will work. If you don't want it soon, please remove it from the queue. >
Ah, CONFIG_X86_LOCAL_APIC is needed for nmi_32.o. I should have noticed before submitting this patch.
thanks, Hiroshi Shimamoto
| |