lkml.org 
[lkml]   [2008]   [May]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/1] checkpatch script: add Blackfin checks for HI/LO and SSYNC/CSYNC macros
    Date
    From: Mike Frysinger <vapier.adi@gmail.com>

    Signed-off-by: Mike Frysinger <vapier.adi@gmail.com>
    Signed-off-by: Bryan Wu <cooloney@kernel.org>
    ---
    scripts/checkpatch.pl | 22 ++++++++++++++++++++++
    1 files changed, 22 insertions(+), 0 deletions(-)

    diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
    index b6bbbcd..44ef399 100755
    --- a/scripts/checkpatch.pl
    +++ b/scripts/checkpatch.pl
    @@ -1126,6 +1126,18 @@ sub process {
    WARN("adding a line without newline at end of file\n" . $herecurr);
    }

    +# Blackfin: use hi/lo macros
    + if ($realfile =~ m@arch/blackfin/.*\.S$@) {
    + if ($line =~ /\.[lL][[:space:]]*=.*&[[:space:]]*0x[fF][fF][fF][fF]/) {
    + my $herevet = "$here\n" . cat_vet($line) . "\n";
    + ERROR("use the LO() macro, not (... & 0xFFFF)\n" . $herevet);
    + }
    + if ($line =~ /\.[hH][[:space:]]*=.*>>[[:space:]]*16/) {
    + my $herevet = "$here\n" . cat_vet($line) . "\n";
    + ERROR("use the HI() macro, not (... >> 16)\n" . $herevet);
    + }
    + }
    +
    # check we are in a valid source file *.[hc] if not then ignore this hunk
    next if ($realfile !~ /\.[hc]$/);

    @@ -1142,6 +1154,16 @@ sub process {
    WARN("CVS style keyword markers, these will _not_ be updated\n". $herecurr);
    }

    +# Blackfin: don't use __builtin_bfin_[cs]sync
    + if ($line =~ /__builtin_bfin_csync/) {
    + my $herevet = "$here\n" . cat_vet($line) . "\n";
    + ERROR("use the CSYNC() macro in asm/blackfin.h\n" . $herevet);
    + }
    + if ($line =~ /__builtin_bfin_ssync/) {
    + my $herevet = "$here\n" . cat_vet($line) . "\n";
    + ERROR("use the SSYNC() macro in asm/blackfin.h\n" . $herevet);
    + }
    +
    # Check for potential 'bare' types
    my ($stat, $cond);
    if ($realcnt && $line =~ /.\s*\S/) {
    --
    1.5.5


    \
     
     \ /
      Last update: 2008-05-31 12:43    [W:0.024 / U:1.160 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site