lkml.org 
[lkml]   [2008]   [May]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] firewire: fw-ohci: clear LinkControl register when enabling the chip
    We want the rcvPhyPkt bit in LinkControl off before we start using the
    chip. However, the spec says that the reset value of it is undefined.
    Hence switch it (and all other bits while we are at it) explicitly off.

    https://bugzilla.redhat.com/show_bug.cgi?id=244576#c48 shows that for
    example the nForce2 integrated FireWire controller seems to have it on
    by default.

    Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
    ---
    drivers/firewire/fw-ohci.c | 1 +
    1 file changed, 1 insertion(+)

    Index: linux/drivers/firewire/fw-ohci.c
    ===================================================================
    --- linux.orig/drivers/firewire/fw-ohci.c
    +++ linux/drivers/firewire/fw-ohci.c
    @@ -1473,6 +1473,7 @@ static int ohci_enable(struct fw_card *c
    reg_write(ohci, OHCI1394_HCControlClear,
    OHCI1394_HCControl_noByteSwapData);

    + reg_write(ohci, OHCI1394_LinkControlClear, ~0);
    reg_write(ohci, OHCI1394_LinkControlSet,
    OHCI1394_LinkControl_rcvSelfID |
    OHCI1394_LinkControl_cycleTimerEnable |
    --
    Stefan Richter
    -=====-==--- -==- ----=
    http://arcgraph.de/sr/


    \
     
     \ /
      Last update: 2008-06-01 01:11    [W:0.021 / U:60.580 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site