Messages in this thread |  | | | Date | Sat, 31 May 2008 08:08:01 +0100 | | From | Jeremy Fitzhardinge <> | | Subject | Re: [PATCH 2 of 5] xn/blkfront: Add the CDROM_GET_CAPABILITY ioctl to blkfront | |
Jeff Garzik wrote:
> Jeremy Fitzhardinge wrote:
>> + case CDROM_GET_CAPABILITY: {
>> + struct gendisk *gd = info->gd;
>> + if (gd->flags & GENHD_FL_CD)
>> + return 0;
>> + return -EINVAL;
>> + }
>
>
> Surely you can come up with a better implementation than this? It's
> just a bitmask returned to userspace...
Unfortunately the Xen block driver interface doesn't seem to pass
through any capabilities of the underlying CDROM device, so there's not
much to return. I suspect this is primarily a hack to make installers a
bit happier installing off a Xen VBD rather than because real programs
will use this in earnest.
J
|  |