lkml.org 
[lkml]   [2008]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 08/15] PNP: in debug resource dump, make empty list obvious
    If the resource list is empty, say that explicitly.  Previously,
    it was confusing because often the heading was followed by zero
    resource lines, then some "add resource" lines from auto-assignment,
    so the "add" lines looked like current resources.

    Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>

    Index: work10/drivers/pnp/support.c
    ===================================================================
    --- work10.orig/drivers/pnp/support.c 2008-05-16 16:01:26.000000000 -0600
    +++ work10/drivers/pnp/support.c 2008-05-16 16:13:42.000000000 -0600
    @@ -77,7 +77,12 @@ void dbg_pnp_show_resources(struct pnp_d
    struct pnp_resource *pnp_res;
    struct resource *res;

    - dev_dbg(&dev->dev, "current resources: %s\n", desc);
    + if (list_empty(&dev->resources)) {
    + dev_dbg(&dev->dev, "%s: no current resources\n", desc);
    + return;
    + }
    +
    + dev_dbg(&dev->dev, "%s: current resources:\n", desc);
    list_for_each_entry(pnp_res, &dev->resources, list) {
    res = &pnp_res->res;

    --


    \
     
     \ /
      Last update: 2008-05-31 00:55    [W:0.027 / U:0.296 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site