Messages in this thread | | | Subject | Re: [patch 4/8] nfsd: rename MAY_ flags | From | Miklos Szeredi <> | Date | Fri, 30 May 2008 11:53:29 +0200 |
| |
> These three constants are very much ingrained in the UNIX tradition, > and it's no accident that the MAY_ flags correspond exactly to the > i_mode bits, which is something often exploited by permission checking > code.
Funny example of naming confusion:
> asmlinkage long sys_faccessat(int dfd, const char __user *filename, int mode) > { > ... > if (mode & ~S_IRWXO) /* where's F_OK, X_OK, W_OK, R_OK? */ > return -EINVAL;
The MAY_* namespace is never mentioned, even though that's the one most relevant here :)
Miklos
| |