lkml.org 
[lkml]   [2008]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [patch 4/8] nfsd: rename MAY_ flags
From
Date
> These three constants are very much ingrained in the UNIX tradition,
> and it's no accident that the MAY_ flags correspond exactly to the
> i_mode bits, which is something often exploited by permission checking
> code.

Funny example of naming confusion:

> asmlinkage long sys_faccessat(int dfd, const char __user *filename, int mode)
> {
> ...
> if (mode & ~S_IRWXO) /* where's F_OK, X_OK, W_OK, R_OK? */
> return -EINVAL;

The MAY_* namespace is never mentioned, even though that's the one
most relevant here :)

Miklos


\
 
 \ /
  Last update: 2008-05-30 11:57    [W:0.077 / U:0.372 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site