Messages in this thread | | | Date | Sat, 03 May 2008 19:25:15 +0200 | From | Jiri Slaby <> | Subject | Re: [PATCH 1/2] OF: clean coding style - prom_parse.c |
| |
On 05/03/2008 05:13 PM, monstr@seznam.cz wrote: > From: Michal Simek <monstr@monstr.eu> > > > Signed-off-by: Michal Simek <monstr@monstr.eu> > --- > arch/powerpc/kernel/prom_parse.c | 98 ++++++++++++++++++-------------------- > 1 files changed, 46 insertions(+), 52 deletions(-) > > diff --git a/arch/powerpc/kernel/prom_parse.c b/arch/powerpc/kernel/prom_parse.c > index 90eb3a3..7c6b07c 100644 > --- a/arch/powerpc/kernel/prom_parse.c > +++ b/arch/powerpc/kernel/prom_parse.c > @@ -31,21 +25,19 @@ static int __of_address_to_resource(struct device_node *dev, > const u32 *addrp, u64 size, unsigned int flags, > struct resource *r); > > - > /* Debug utility */ > #ifdef DEBUG > static void of_dump_addr(const char *s, const u32 *addr, int na) > { > - printk("%s", s); > - while(na--) > - printk(" %08x", *(addr++)); > - printk("\n"); > + printk(KERN_INFO "%s", s); > + while (na--) > + printk(KERN_INFO " %08x", *(addr++)); > + printk(KERN_INFO "\n");
This is wrong you'll get string <6> XXXXXXXX <6> XXXXXXX ... <6>
| |