Messages in this thread | | | Date | Thu, 29 May 2008 16:51:50 -0400 | From | "Mike Frysinger" <> | Subject | Re: [PATCH] nommu: fix kobjsize() for SLOB and SLUB |
| |
On Thu, May 29, 2008 at 4:30 PM, Christoph Lameter wrote: > On Thu, 29 May 2008, Mike Frysinger wrote: >> On Thu, May 29, 2008 at 9:03 AM, David Howells wrote: >> > Mike Frysinger <vapier.adi@gmail.com> wrote: >> >> > I fixed it by setting ARCH_KMALLOC_MINALIGN and ARCH_SLAB_MINALIGN. >> >> >> >> what was the change exactly ? >> > >> > The attached patch. >> > >> > diff --git a/include/asm-frv/mem-layout.h b/include/asm-frv/mem-layout.h >> > +#define ARCH_KMALLOC_MINALIGN 8 >> > +#define ARCH_SLAB_MINALIGN 8 >> >> yeah, we were already doing that ... and the problem we had that i >> referred to seems to be merged already into mainline, so you shouldnt >> run into it unless you're using older kernel versions > > You should not have to do this. This is the default alignment that also > SLOB needs to follow. We need to align structures correctly for access to > long long's.
are you saying that slob is broken ? i see in mm/slob.c: #ifndef ARCH_KMALLOC_MINALIGN #define ARCH_KMALLOC_MINALIGN __alignof__(unsigned long) #endif -mike
| |