lkml.org 
[lkml]   [2008]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] tmpfs: support aio
On Wed, 28 May 2008, Harvey Harrison wrote:
> On Wed, 2008-05-28 at 16:58 -0700, Andrew Morton wrote:
> >
> > count = 0;
> > retval = generic_segment_checks(iov, &nr_segs, &count, VERIFY_WRITE);
> > if (retval)
> > return retval;
> > if (count == 0)
> > return 0;
> >
> > retval = 0;
>
> retval has to be 0 here, no need to assign it again?

You're right, thanks: it was even more obviously stupid in my patch.
That came from copying generic_file_aio_read, then removing its O_DIRECT
block: though now I look closer, it's actually just as redundant in the
original. I'll fix that up in the shmem.c and filemap.c patches to follow.

Hugh


\
 
 \ /
  Last update: 2008-05-29 20:29    [W:0.051 / U:0.404 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site