lkml.org 
[lkml]   [2008]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 1/5] [MIPS] fix sparse warning about setup_early_printk()
Date
This patch fixes the following sparse warning:

<<<<<<<<

arch/mips/kernel/early_printk.c:35:13: warning: symbol 'setup_early_printk'
was not declared. Should it be static?

<<<<<<<<

The fix is to define a prototype of the setup_early_printk() function and
to include the appropriate header into arch/mips/kernel/early_printk.c.

Signed-off-by: Dmitri Vorobiev <dmitri.vorobiev@movial.fi>
---
arch/mips/kernel/early_printk.c | 1 +
arch/mips/kernel/setup.c | 6 +-----
include/asm-mips/setup.h | 2 ++
3 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/arch/mips/kernel/early_printk.c b/arch/mips/kernel/early_printk.c
index 9dccfa4..cb602c1 100644
--- a/arch/mips/kernel/early_printk.c
+++ b/arch/mips/kernel/early_printk.c
@@ -7,6 +7,7 @@
* Copyright (C) 2007 MIPS Technologies, Inc.
* written by Ralf Baechle (ralf@linux-mips.org)
*/
+#include <asm/setup.h>
#include <linux/console.h>
#include <linux/init.h>

diff --git a/arch/mips/kernel/setup.c b/arch/mips/kernel/setup.c
index c6a063b..0370794 100644
--- a/arch/mips/kernel/setup.c
+++ b/arch/mips/kernel/setup.c
@@ -557,11 +557,7 @@ void __init setup_arch(char **cmdline_p)
prom_init();

#ifdef CONFIG_EARLY_PRINTK
- {
- extern void setup_early_printk(void);
-
- setup_early_printk();
- }
+ setup_early_printk();
#endif
cpu_report();
check_bugs_early();
diff --git a/include/asm-mips/setup.h b/include/asm-mips/setup.h
index 70009a9..883f59b 100644
--- a/include/asm-mips/setup.h
+++ b/include/asm-mips/setup.h
@@ -3,4 +3,6 @@

#define COMMAND_LINE_SIZE 256

+extern void setup_early_printk(void);
+
#endif /* __SETUP_H */
--
1.4.4.3


\
 
 \ /
  Last update: 2008-05-29 17:19    [W:0.048 / U:0.244 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site