Messages in this thread | | | Date | Thu, 29 May 2008 08:48:55 -0600 | From | "Chris Friesen" <> | Subject | Re: [PATCH] net: add ability to clear stats via ethtool - e1000/pcnet32 |
| |
James Cammarata wrote: >> You didn't provide a reason from adding this feature to the kernel.
> Sorry, my reasoning was in my original patch only. The ability to reset > network counters is, in my experience, one of the first things you do > when trying to troubleshoot networking issues - especially when you have > incrementing errors.
The ability to reset counters does make it easier to detect changes manually, as any non-zero value is something of interest. However, if you're gathering data via a script there is no functional gain.
>> Many of the kernel's accounting accumulators cannot be reset. We >> handle that in userspace tools by using subtraction.
> I don't think that should preclude the ability to reset these, unless it is > shown that it would break something very badly.
You're trying to add new functionality to the kernel, increasing its size and adding more work for maintainers. Also, you're implicitly asking that all of the network drivers be updated to add support for this feature. The burden of proof is on you to show why the feature is useful enough that the others involved should take on this additional work.
Chris
| |