lkml.org 
[lkml]   [2008]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] Char: vt, make sysfs operations atomic
On Tue, 27 May 2008 16:48:58 -0400
Aristeu Rozanski <aris@ruivo.org> wrote:

> >> the reason for the code be the way it is is because vcs_{add,remove}_sysfs()
> >> may sleep
> >
> > What's the point? To have races in the code but not sleep inside the semaphore?
> what about fixing the code to remove the race _and_ not sleep inside the
> semaphore? :)
>

The patch does fix a race, by extending console_sem coverage to provide
exclusion between the sysfs creation and teardown operations.

I assume - no race was identified in the changelog. Can we actually
simultaneously run con_open() and con_close() against the same device?
I guess it might be possible if userspace tried hard enough.

I renamed the patch to the much more accurate "vt: hold console_sem
across sysfs operations" - "atomic" in the kernel context means "cannot
context switch" and nothing "atomic" is happening in this patch.



\
 
 \ /
  Last update: 2008-05-29 00:59    [W:0.039 / U:0.488 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site