Messages in this thread | | | Date | Wed, 28 May 2008 13:25:50 -0700 (PDT) | From | Christoph Lameter <> | Subject | Re: [PATCH] nommu: fix kobjsize() for SLOB and SLUB |
| |
On Wed, 28 May 2008, Pekka Enberg wrote:
> (cc'ing linux-kernel) > > Paul Mundt wrote: > > I have no idea why you are maintaining the page->index case here, it's > > completely broken for page cache pages. Unless someone more familiar with > > the page->index BUG_ON() tests objects, the BUG_ON() there should be > > removed completely. Neither Christoph nor I were able to work out what the > > point of the page->index tests were, and no one else has spoken up about > > them, so it's likely safe to treat them as bogus. > > We use kobjsize() for pointers returned from do_mmap() which is why I kept the > page->index case. Are we using PageCompound for those as well?
What does do_mmap have to do with page->index?
| |