lkml.org 
[lkml]   [2008]   [May]   [28]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateWed, 28 May 2008 12:51:04 +0800
FromLi Zefan <>
SubjectRe: [PATCH] call_usermodehelper() increase reliability
KOSAKI Motohiro wrote:
> Now, call_usermodehelper_setup() uses GFP_ATOMIC.
> but it can return NULL _very_ easily.
> 
> GFP_ATOMIC is needed only when we can't sleep.
> and, GFP_KERNEL is robust and better.
> 
> thus, I add gfp_mask argument to call_usermodehelper_setup().
> 
> So, its caller pass below,
> 
> call_usermodehelper() and call_usermodehelper_keys(): 
> 	depend on 'wait' argument.
> call_usermodehelper_pipe():
> 	always GFP_KERNEL because always run under process context.
> orderly_poweroff():
> 	pass to GFP_ATOMIC because may run under interrupt context.
> 

I have no problem with this patch.

Reviewed-by: Li Zefan <lizf@cn.fujitsu.com>


\
 
 \ /
  Last update: 2008-05-28 07:25    [from the cache]
©2003-2008