Messages in this thread |  | | | Date | Wed, 28 May 2008 03:01:47 +0300 | | From | "Felipe Balbi" <> | | Subject | Re: HAVE_CLK (for <linux/clk.h> support) |
| |
Hi,
On Wed, May 28, 2008 at 2:14 AM, David Brownell <david-b@pacbell.net> wrote: > On Tuesday 27 May 2008, Felipe Balbi wrote: >> This patch adds support for MUSB and TUSB controllers >> integrated into omap2430 and davinci. It also adds support >> for external tusb6010 controller. > > The most significant issue I know of with this patch [0] is actually > an arch issue. On ones like x86, with no support for the clock API, > this driver will build but not link: > > ERROR: "clk_enable" [drivers/usb/musb/musb_hdrc.ko] undefined! > ERROR: "clk_disable" [drivers/usb/musb/musb_hdrc.ko] undefined! > ERROR: "clk_put" [drivers/usb/musb/musb_hdrc.ko] undefined! > ERROR: "clk_get" [drivers/usb/musb/musb_hdrc.ko] undefined! > > I don't know of any other drivers with this particular issue, > but nonetheless ... I think the following is an appropriate > resolution. > > Comments from anyone else?
I actually like it. I didn't see this error cuz I was only building musb for arm architecture.
But why only davinci and omap? What about: mach-aaec2000, mach-at91, mach-ep93xx, mach-integrator, mach-lh7a40x, mach-ns9xxx, mach-pnx4008, mach-pxa, mach-realview, mach-sa1100, mach-versatile, mach-s3c24x.
-- Best Regards,
Felipe Balbi felipebalbi@users.sourceforge.net
|  |