Messages in this thread |  | | | Date | Tue, 27 May 2008 09:20:06 +0300 | | From | "Pekka Enberg" <> | | Subject | Re: possible double call of kfree_skb in net/llc/llc_sap.c |
Dmitry Petukhov wrote:
>> In the file net/llc/llc_sap.c, funcion llc_sap_state_process,
>> the call to kfree_skb in the line 227 can proceed even if skb was already
>> freed
>> on line 218, or 224, or queued to the user within sock_queue_rcv_skb
>> function.
>> Obviously return statement is missing after line 225.
>>
>> This problem was found by Alex Shevkov.
On Tue, May 27, 2008 at 9:16 AM, Patrick McHardy <kaber@trash.net> wrote:
> Could you send a patch please?
I wonder how the code got in that shape but it's probably best to just
remove the extra kfree_skb() calls and do it unconditionally at the
end of the function.
|  |