lkml.org 
[lkml]   [2008]   [May]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: amd64-agp: resume but too late?
On Mon, 26 May 2008, Pavel Machek wrote:
> Hi!
>
> I don't get it:
>
> --- a/drivers/char/agp/amd64-agp.c
> +++ b/drivers/char/agp/amd64-agp.c
> @@ -549,6 +549,8 @@ static int agp_amd64_suspend(struct pci_
> return 0;
> }
>
> +/* FIXME: this is strange; we enable iommu translation here, but that
> + * may be too late, no? */
> static int agp_amd64_resume(struct pci_dev *pdev)
> {
> pci_set_power_state(pdev, PCI_D0);
>
> ...but resume is normal pci device, so other devices may be resumed
> before this one, and already depend on iommu running...
>
> How is this supposed to work? Should agp_amd64_resume be called from
> sysdev or something like that?

Hmm, you sent a patch some days ago to change it to
suspend_late/resume_early. Is the discussion resolved about that ?

Thanks,
tglx


\
 
 \ /
  Last update: 2008-05-27 14:21    [W:0.048 / U:0.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site