lkml.org 
[lkml]   [2008]   [May]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH 1/2] mmc_spi: export probe and remove functions
On Fri, 23 May 2008 22:28:34 +0400
Anton Vorontsov <avorontsov@ru.mvista.com> wrote:

> ...so we'll able to write bindings for the OpenFirmware without
> messing with #ifdefs in the driver itself.
>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>

This looks extremely wrong. Encapsulating probe functions isn't exactly
in line with the device model and bound to confuse people.

Your patches doesn't give a complete picture of the OF side of things,
but can't you solve this by having an init callback somewhere?

Rgds
--
-- Pierre Ossman

Linux kernel, MMC maintainer http://www.kernel.org
rdesktop, core developer http://www.rdesktop.org


\
 
 \ /
  Last update: 2008-05-26 14:21    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site