lkml.org 
[lkml]   [2008]   [May]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/1] Char: vt, make sysfs operations atomic
    Date
    Hold console sem while creating/destroying sysfs files. Serialisation is
    so far done by BKL held in tty release_dev and chrdev_open, but no other
    locks are held in open path.

    Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
    Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
    ---
    drivers/char/vt.c | 4 ++--
    1 files changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/char/vt.c b/drivers/char/vt.c
    index fa1ffbf..0043cff 100644
    --- a/drivers/char/vt.c
    +++ b/drivers/char/vt.c
    @@ -2746,8 +2746,8 @@ static int con_open(struct tty_struct *tty, struct file *filp)
    tty->termios->c_iflag |= IUTF8;
    else
    tty->termios->c_iflag &= ~IUTF8;
    - release_console_sem();
    vcs_make_sysfs(tty);
    + release_console_sem();
    return ret;
    }
    }
    @@ -2772,8 +2772,8 @@ static void con_close(struct tty_struct *tty, struct file *filp)
    if (vc)
    vc->vc_tty = NULL;
    tty->driver_data = NULL;
    - release_console_sem();
    vcs_remove_sysfs(tty);
    + release_console_sem();
    mutex_unlock(&tty_mutex);
    /*
    * tty_mutex is released, but we still hold BKL, so there is
    --
    1.5.4.5


    \
     
     \ /
      Last update: 2008-05-26 13:57    [W:0.019 / U:29.936 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site