Messages in this thread |  | | | Date | Mon, 26 May 2008 13:37:51 +0900 | | From | KOSAKI Motohiro <> | | Subject | Re: [PATCH 1/3] page-flags: record page flag overlays explicitly | |
Hi
Thank you nice patch.
> Some page flags are used for more than one purpose, for example
> PG_owner_priv_1. Currently there are individual accessors for each user,
> each built using the common flag name far away from the bit definitions.
> This makes it hard to see all possible uses of these bits.
>
> Now that we have a single enum to generate the bit orders it makes sense
> to express overlays in the same place. So create per use aliases for
> this bit in the main page-flags enum and use those in the accessors.
>
> Signed-off-by: Andy Whitcroft <apw@shadowen.org>
My review found no bug.
Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
|  |