lkml.org 
[lkml]   [2008]   [May]   [26]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateMon, 26 May 2008 10:55:09 +0200 (CEST)
FromJiri Kosina <>
SubjectRe: [PATCH] hiddev: Switch to unlocked_ioctl
On Thu, 22 May 2008, Alan Cox wrote:

> Push down the BKL. In some cases compat_ioctl already doesn't take the
> BKL so we don't either. 

Thanks.

> @@ -555,7 +559,10 @@ static int hiddev_ioctl(struct inode *inode, struct file *file, unsigned int cmd
>  	struct usbhid_device *usbhid = hid->driver_data;
>  	void __user *user_arg = (void __user *)arg;
>  	int i;
> +	
> +	/* Called without BKL by compat methods so no BKL taken */
> 
> +	/* FIXME: Who or what stop this racing with a disconnect ?? */
>  	if (!hiddev->exist)
>  		return -EIO;

Oliver (added to CC) -- I vaguely remember you already fixing this race, 
but I don't seem to be able to find the patch anywhere. Do I just remember 
incorrectly?

Thanks,

-- 
Jiri Kosina


\
 
 \ /
  Last update: 2008-05-26 10:57    [from the cache]
©2003-2008