Messages in this thread | | | Subject | Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option | From | Alexandre Oliva <> | Date | Sun, 25 May 2008 14:17:57 -0300 |
| |
On May 25, 2008, Marcel Holtmann <marcel@holtmann.org> wrote:
> in the early days we had something like three drivers using the > request_firmware() and it was understood between the authors what the > filename was meant for.
You're contradicting yourself. Is it a filename, or is it not? Earlier, you said it wasn't, it was just a name that userspace was supposed to map to a filename. Now, you're saying it is a filename.
Clearly (to me) your wish to prohibit '/'s in the firmware name has to do with an attempt to force a distiction, to make the firmware a filename rather than a pathname. But, as you said yourself, the mapping from firmware name is supposed to be entirely handled in userland, therefore it doesn't even begin to make sense to distinguish between filenames and pathnames. You'd have to make assumptions that (i) the firmware name names files (with built-in firmware, it doesn't), and, if it is about filenames, (ii) what the pathname separator character is. Should '\\' be ruled out as well, because someone might want /lib/firmware to be in a FAT filesystem?
nWouldn't it be better to leave the resolution of firmware names to content *entirely* up to userland? Say, if userland wants to implement something very similar to the key-to-data map in-kernel built-in firmware, this would work just fine, without any artificial constraints?
-- Alexandre Oliva http://www.lsd.ic.unicamp.br/~oliva/ Free Software Evangelist oliva@{lsd.ic.unicamp.br, gnu.org} FSFLA Board Member ¡Sé Libre! => http://www.fsfla.org/ Red Hat Compiler Engineer aoliva@{redhat.com, gcc.gnu.org} -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |