lkml.org 
[lkml]   [2008]   [May]   [25]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
FromMarin Mitov <>
Subjectpci_set_consistent_dma_mask() question
DateSun, 25 May 2008 08:43:47 +0300
Hi all,

In the file: Documentation/DMA-mapping.txt is written:

pci_set_consistent_dma_mask() will always be able to set the same or a
smaller mask as pci_set_dma_mask(). However for the rare case that a
device driver only uses consistent allocations, one would have to
check the return value from pci_set_consistent_dma_mask().

grep-ing drivers/net/* shows that in many drivers 
the return value of pci_set_consistent_dma_mask() is checked
in the path where pci_set_dma_mask() was already successfull.
Sure, this is during driver's initiallysation, so it is not time critical.
My question: Is it worth to remove the unnecessary checks?
I could prepare patches if you find it worthfull.

Best regards.

Marin Mitov


\
 
 \ /
  Last update: 2008-05-25 07:47    [from the cache]
©2003-2008