Messages in this thread | | | Date | Fri, 23 May 2008 05:26:26 -0400 | From | Christoph Hellwig <> | Subject | Re: [patch 11/14] vfs: move executable checking into ->permission() |
| |
On Wed, May 21, 2008 at 07:15:09PM +0200, Miklos Szeredi wrote: > From: Miklos Szeredi <mszeredi@suse.cz> > > For execute permission on a regular files we need to check if file has > any execute bits at all, regardless of capabilites. > > This check is normally performed by generic_permission() but was also > added to the case when the filesystem defines its own ->permission() > method. In the latter case the filesystem should be responsible for > performing this check. > > So create a helper function exec_permission() that checks returns > -EACCESS if MAY_EXEC is present, the inode is a regular file and no > execute bits are present in inode->i_mode. > > Call this function from filesystems which don't call > generic_permission() from their ->permission() methods and which > aren't already performing this check. Also remove the check from > dentry_permission(). > > The new code should be equivalent to the old.
There's no point moving this into the filesystem.
| |