Messages in this thread | | | Date | Fri, 23 May 2008 12:06:17 +0100 | From | Alan Cox <> | Subject | Re: [PATCH] x86: Switch apm to unlocked_kernel |
| |
On Fri, 23 May 2008 11:03:53 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Alan, > > On Thu, 22 May 2008 21:22:04 +0100 Alan Cox <alan@lxorguk.ukuu.org.uk> wrote: > > > > This pushes the lock a fair way down and the final kill looks like it > > should be an easy project for someone who wants to have a shot at it. > > and makes some gratuitous stylistic changes as well. Please don't do > that!
Andrew shouts at me if I send him patches that don't fix the style of the lines around so you get some style changes even when I cut bits out of diffs. I think that approach is *stupid* too and style should be done after for the entire file.
Alan
| |