lkml.org 
[lkml]   [2008]   [May]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC] x86: merging nmi 32/64 to nmi.c v2
    On Wed, 21 May 2008, Cyrill Gorcunov wrote:
    >
    > Here is updated version (thanks Hiroshi) - I've moved these funcs
    > to traps_64.c and it's compiled just fine (so we are going closer
    > to merge someday even traps-32/64 ;)

    Cyrill,

    I really like that patch, but I'm a bit wary about the doit in one go
    approach. Its pretty hard to review that way and in case of breakage
    bisecting will just point to one large diff which is hard to decode.

    Can you please try to make this a more fine grained patch series ?

    Gradually add/modify the two files so they are identical at the
    end. There are a couple of obvious steps, e.g. the move of function to
    traps_*.c and adding the inline functions like get_timer_irqs().

    Thanks,
    tglx


    \
     
     \ /
      Last update: 2008-05-22 23:41    [W:0.020 / U:118.548 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site