Messages in this thread |  | | | Date | Thu, 22 May 2008 22:18:29 +0200 | | From | "Hans J. Koch" <> | | Subject | Re: [PATCH 01/03] uio: Add enable_irq() callback |
| |
On Wed, May 21, 2008 at 08:58:24PM +0900, Magnus Damm wrote: > On Tue, May 20, 2008 at 7:51 PM, Magnus Damm <magnus.damm@gmail.com> wrote: > > Add enable_irq() callback to struct uio_info. This callback is needed by > > the uio_platform driver so interrupts can be enabled before blocking. > > We can most likely use a single uio platform driver if this patch is > acceptable. Any NAKs?
Yes. Your approach only allows enabling interrupts, but not disabling them. And I don't like that it is not possible for generic userspace tools to find out if a UIO device has this auto-irq-enabling capability or not.
I just posted a patch that allows enabling _and_ disabling of irqs from userspace by writing 0 or 1 to /dev/uioX. I've CCed you, could you please test? If this doesn't do what you need, please let me know.
Thanks, Hans
|  |