Messages in this thread | | | Date | Thu, 22 May 2008 19:13:56 +0300 | From | "Pekka Enberg" <> | Subject | Re: [RFC/PATCH 1/3] SLAB: Add PageSlab checking to ksize() |
| |
Hi Matt,
On Thu, May 22, 2008 at 6:01 PM, Matt Mackall <mpm@selenic.com> wrote: > As I've said several times, ksize() on kmem_cache_alloced objects > -cannot work- on SLOB. Calling ksize() on something returned by > kmem_cache_alloc is a categorical error.
Well, it's a historical fact that ksize() worked for both kmalloc() and kmem_cache_alloc() (see the kernedoc comment in mm/slab.c). However, I think we should just look at getting rid of ksize() altogether as it's only (ab)used by the nommu code and few call-sites that open-code krealloc().
Pekka
| |