lkml.org 
[lkml]   [2008]   [May]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] fix sys_prctl() returned uninitialized value
On Wed, 21 May 2008 22:01:17 -0700 "Andrew G. Morgan" <morgan@kernel.org> wrote:

> this is the default expected by the subsequent switch ().
>

oh gawd.

>
> diff --git a/kernel/sys.c b/kernel/sys.c
> index 895d2d4..cb25a64 100644
> --- a/kernel/sys.c
> +++ b/kernel/sys.c
> @@ -1657,6 +1657,8 @@ asmlinkage long sys_prctl(int option, unsigned long arg2, unsigned long arg3,
> if (security_task_prctl(option, arg2, arg3, arg4, arg5, &error))
> return error;

All along I was believing that it was _this_ return which was causing
the problem.

> + error = 0;
> +
> switch (option) {
> case PR_SET_PDEATHSIG:
> if (!valid_signal(arg2)) {

But now I see it.


This was a hard way to write a changelog.


\
 
 \ /
  Last update: 2008-05-22 07:21    [from the cache]
©2003-2011 Jasper Spaans