Messages in this thread | | | Date | Thu, 22 May 2008 09:22:10 -0500 | From | "Steve French" <> | Subject | Re: [CIFS] Fix reversed memset arguments. |
| |
Dave Jones <davej@redhat.com> wrote on 05/22/2008 08:07:22 AM: Merged into cifs-2.6.git
Thanks for spotting this.
> size is the 3rd argument. > > Signed-off-by: Dave Jones <davej@redhat.com> > > --- linux-2.6/fs/cifs/inode.c~ 2008-05-22 09:05:31.000000000 -0400 > +++ linux-2.6/fs/cifs/inode.c 2008-05-22 09:05:58.000000000 -0400 > @@ -172,7 +172,7 @@ static void fill_fake_finddataunix(FILE_ > { > struct inode *pinode = NULL; > > - memset(pfnd_dat, sizeof(FILE_UNIX_BASIC_INFO), 0); > + memset(pfnd_dat, 0, sizeof(FILE_UNIX_BASIC_INFO)); > > /* __le64 pfnd_dat->EndOfFile = cpu_to_le64(0); > __le64 pfnd_dat->NumOfBytes = cpu_to_le64(0); > @@ -384,7 +384,7 @@ static int get_sfu_mode(struct inode *in > static void fill_fake_finddata(FILE_ALL_INFO *pfnd_dat, > struct super_block *sb) > { > - memset(pfnd_dat, sizeof(FILE_ALL_INFO), 0); > + memset(pfnd_dat, 0, sizeof(FILE_ALL_INFO)); > > /* __le64 pfnd_dat->AllocationSize = cpu_to_le64(0); > __le64 pfnd_dat->EndOfFile = cpu_to_le64(0); > -- > http://www.codemonkey.org.uk
-- Thanks,
Steve
| |