lkml.org 
[lkml]   [2008]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] fix sys_prctl() returned uninitialized value
When we test kernel by the latest LTP(20080430) on ia64,
the following failure occured:
-------------------------------------
prctl01 1 PASS : Test Passed
prctl01 0 WARN : prctl() returned 2048 errno = 0 : Success
prctl01 1 PASS : Test Passed
prctl01 2 FAIL : Test Failed
-------------------------------------
We found commit 3898b1b4ebff8dcfbcf1807e0661585e06c9a91c
causes this failure by git-bisect.
And, we found 'error' has not been initialized in the function
sys_prctl()(kernel/sys.c). When the capability module is not taking
responsibility for this call, sys_prctl() may return a wrong value.

Now, i fixed it.

Signed-off-by: Shi Weihua <shiwh@cn.fujitsu.com>
---
diff --git a/kernel/sys.c b/kernel/sys.c
index 895d2d4..26eb0f7 100644
--- a/kernel/sys.c
+++ b/kernel/sys.c
@@ -1652,7 +1652,7 @@ asmlinkage long sys_umask(int mask)
asmlinkage long sys_prctl(int option, unsigned long arg2, unsigned long arg3,
unsigned long arg4, unsigned long arg5)
{
- long uninitialized_var(error);
+ long error = 0;

if (security_task_prctl(option, arg2, arg3, arg4, arg5, &error))
return error;


\
 
 \ /
  Last update: 2008-05-22 05:23    [W:0.076 / U:0.336 seconds]
©2003-2014 Jasper Spaans. Advertise on this site