lkml.org 
[lkml]   [2008]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC/PATCH 3/3] SLOB: make ksize() more strict for page allocator pass-through
On Wed, 21 May 2008, Pekka Enberg wrote:

> Matt Mackall wrote:
> > We already know users (ie nommu memory usage reporting) are abusing this
> > interface. Making them blow up is unnecessary. Just give them wrong
> > answers. Issuing a warning might be a good idea for debugging.
>
> But kobjsize() never calls ksize() with SLOB as it doesn't set PageSlab. Or
> are you talking about something else here?
>
> Matt Mackall wrote:
> > Second, I'd prefer to keep this sort of debugging code out of SLOB.
> > SLUB is much better suited to debugging allocator abuse.
>
> Fair enough. I'll drop the patch.

I also would prefer to keep this out of SLUB. Set/Clear PageSlab dirties
the cacheline and it forces the unlining of kmalloc_large.



\
 
 \ /
  Last update: 2008-05-21 23:17    [W:0.043 / U:0.248 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site