[lkml]   [2008]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [patch 07/14] vfs: pass dentry to permission()
    On Wed, May 21, 2008 at 07:15:05PM +0200, Miklos Szeredi wrote:
    > From: Miklos Szeredi <>
    > The following patches clean up the i_op->permission() method and the
    > related VFS API.
    > Here's an overview of the changes:
    > - ->permission() is passed a dentry instead of an inode
    > - ->permission() is passed a integer flags parameter instead of a
    > nameidata pointer

    No. Take a good look at the instances.

    a) only one aberrant case cares about dentry, and for extremely
    wrong reasons. /proc/sys/ stuff. ecryptfs, of course, will be happy
    with any variant.
    b) few flags that are looked at are trivially mapped to new MAY_...

    I have a patch series that does it, but it involves tons of fixing the
    sysctl handling to be finished ;-/ And yes, we need sysctl to quit
    doing the "I want to get ctl_table entry, so I'll do very painful search
    by dentry every damn time" in any case - look at that code, it's far
    too ugly to live.

    IOW, consider this ->permission() API change NAKed.

     \ /
      Last update: 2008-05-21 22:33    [W:0.020 / U:9.080 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site