Messages in this thread | | | Date | Wed, 21 May 2008 22:57:25 +0400 | From | Cyrill Gorcunov <> | Subject | Re: CFD: (was [PATCH] Standard indentation of arguments) |
| |
[Andrew Morton - Wed, May 21, 2008 at 10:46:44AM -0700] | On Wed, 21 May 2008 08:09:39 -0400 Theodore Tso <tytso@mit.edu> wrote: | | > On Wed, May 21, 2008 at 06:32:06AM -0400, Christoph Hellwig wrote: | > > On Wed, May 21, 2008 at 01:50:37AM -0700, Andrew Morton wrote: | > > > Oh, what a marvellous way to encourage new contributors that was. Thank | > > > you so much. | > > > | > > > For the record: Al speaks only for himself and a lack of expressed | > > > disagrement from others should not be taken as agreement. | > > | > > But I'd like to second the opinion. This is getting a little too far. | > > We should rather try to at least enforce very basic standards a lot of | > > the crap shoved in doesn't follow instead of wanking around about exact | > > placement of whitespaces. | > | > The real question is whether people who are wanking about whitespace | > and spelling fixes in comments will graduate to writing real, useful | > patches. If they won't, there's no point to encouraging them. | > | | Guys, get a clue. It doesn't matter what that person did. It is the | effect upon *all* other potential developers which is so damaging here. | Not upon this individual. |
Btw, we have CodingStyle, SubmittingPatches and other, but why don't we have something like KernelNewbieGuide? Don't get me wrong, but there could be written all rules about - what is good to do, what is bad. So a newbiew who wants to be usefull for kernel could read it and decide what should be done. /Don't beat me ;) / And of course I know about kernelnewbie.org but this (even quite short) document could help I think.
- Cyrill -
| |