lkml.org 
[lkml]   [2008]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC][PATCH 2/3] memcg:: seq_ops support for cgroup
On Tue, 20 May 2008 22:06:48 -0700
"Paul Menage" <menage@google.com> wrote:

> >
> > And (*read) method isn't useful ;)
> >
> > Can we add new stat file dynamically ?
>
> Yes, there's no reason we can't do that. Right now it's not possible
> to remove a control file without deleting the cgroup, but I have a
> patch that supports removal.
>
Good news. I'll wait for.

> The question is whether it's better to have one file per CPU/node or
> one large complex file.
>
For making the kernel simple, one-file-per-entity(cpu/node...) is better.
For making the applications simple, one big file is better.

I think recent interfaces uses one-file-per-entity method. So I vote for it
for this numastat. One concern is size of cpu/node. It can be 1024...4096 depends
on environment.

open/close 4096 files took some amount of cpu time.
(And that's why 'ps' command is slow on big system.)

Thanks,
-Kame



\
 
 \ /
  Last update: 2008-05-21 08:05    [W:0.065 / U:0.912 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site