lkml.org 
[lkml]   [2008]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH] net/ipv4/arp.c: Use the exported hex_asc from lib/hexdump.c instead
    From bc47e710a3ebd8a5989404f711a051b6516d01ed Mon Sep 17 00:00:00 2001
    From: Denis Cheng <crquan@gmail.com>
    Date: Wed, 21 May 2008 09:43:32 +0800
    Subject: [PATCH] net/ipv4/arp.c: Use common hex_asc helpers

    Here the local hexbuf is a duplicate of global const char hex_asc from
    lib/hexdump.c, except the hex letters' cases:

    const char hexbuf[] = "0123456789ABCDEF";

    const char hex_asc[] = "0123456789abcdef";

    and here to print HW addresses, the hex cases are not significant.

    Thanks to Harvey Harrison to introduce the hex_asc_hi/hex_asc_lo helpers.

    Signed-off-by: Denis Cheng <crquan@gmail.com>
    Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
    Acked-by: David S. Miller <davem@davemloft.net>
    ---
    net/ipv4/arp.c | 5 ++---
    1 files changed, 2 insertions(+), 3 deletions(-)

    diff --git a/net/ipv4/arp.c b/net/ipv4/arp.c
    index 418862f..9b539fa 100644
    --- a/net/ipv4/arp.c
    +++ b/net/ipv4/arp.c
    @@ -1288,7 +1288,6 @@ static void arp_format_neigh_entry(struct seq_file *seq,
    struct neighbour *n)
    {
    char hbuffer[HBUFFERLEN];
    - const char hexbuf[] = "0123456789ABCDEF";
    int k, j;
    char tbuf[16];
    struct net_device *dev = n->dev;
    @@ -1302,8 +1301,8 @@ static void arp_format_neigh_entry(struct seq_file *seq,
    else {
    #endif
    for (k = 0, j = 0; k < HBUFFERLEN - 3 && j < dev->addr_len; j++) {
    - hbuffer[k++] = hexbuf[(n->ha[j] >> 4) & 15];
    - hbuffer[k++] = hexbuf[n->ha[j] & 15];
    + hbuffer[k++] = hex_asc_hi(n->ha[j]);
    + hbuffer[k++] = hex_asc_lo(n->ha[j]);
    hbuffer[k++] = ':';
    }
    hbuffer[--k] = 0;
    --
    1.5.4.3

    \
     
     \ /
      Last update: 2008-05-21 04:31    [W:0.032 / U:30.288 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site