lkml.org 
[lkml]   [2008]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [RFC PATCH 1/3] Implement generic freeze feature
Date
Hi,

Andreas Dilger wrote:
>> +static int ioctl_freeze(struct file *filp)
>> +{
>> + struct super_block *sb = filp->f_path.dentry->d_inode->i_sb;
>> +
>> + if (!capable(CAP_SYS_ADMIN))
>> + return -EPERM;
>> +
>> + /* If filesystem doesn't support freeze feature, return. */
>> + if (sb->s_op->write_super_lockfs == NULL)
>> + return -EINVAL;
>
> Should this be EINVAL, or EOPNOTSUPP? Usually EINVAL means there is
> something wrong with the passed ioctl parameters (e.g. bad value),
> while EOPNOTSUPP is "operation not supported" and makes more sense.

Sounds good.
I will send new patch-set which is rebased to 2.6.26-rc3 and includes
this fix, in this weekend.

Cheers, Takashi


\
 
 \ /
  Last update: 2008-05-21 03:27    [W:0.038 / U:0.184 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site