Messages in this thread | | | Date | Wed, 21 May 2008 02:18:43 +0100 | From | Al Viro <> | Subject | Re: [PATCH] or51132.c: unaligned |
| |
On Tue, May 20, 2008 at 05:55:38PM -0700, Linus Torvalds wrote: > > > > + return buf[0] | (buf[1] << 8); > > > > > > return get_unaligned_le16(buf); > > > > And the point of that would be? > > Perhaps better code generation?
FWIW, I wonder how they really compare on misaligned and whether it would make sense for gcc to try and generate a single load on targets that are known to allow that...
Hell knows; I still find explicit variant more readable in this case and AFAICS it's not a critical path...
| |