Messages in this thread | | | Date | Wed, 21 May 2008 11:13:40 +1000 | From | Paul Mackerras <> | Subject | Re: [PATCH 1/2] Remove all users of cpu_to_{le|be}{16|32|64}p |
| |
Harvey Harrison writes:
> @@ -602,9 +600,7 @@ static inline __hc32 cpu_to_hc32 (const struct ohci_hcd *ohci, const u32 x) > > static inline __hc32 cpu_to_hc32p (const struct ohci_hcd *ohci, const u32 *x) > { > - return big_endian_desc(ohci) ? > - cpu_to_be32p(x) : > - cpu_to_le32p(x); > + return big_endian_desc(ohci) ? cpu_to_be32(*x) : cpu_to_le32(*x);
Please don't do this, because it means we don't get to use the byte-reversing loads and stores on powerpc, and end up using several instructions instead of one.
Paul.
| |