Messages in this thread |  | | | From | Roland McGrath <> | | Subject | Re: [PATCH 1/2] signals: collect_signal: remove the unneeded sigismember() check | | Date | Tue, 20 May 2008 17:56:46 -0700 (PDT) |
| |
> collect_signal() checks sigismember(&list->signal, sig), this is not needed. > This "sig" was just found by next_signal(), so it must be valid.
Acked-by: Roland McGrath <roland@redhat.com>
> We have a (completely broken) call to ->notifier in between, but it must not > play with sigpending->signal bits or unlock ->siglock.
The only use of ->notifier/notifier_mask is for block_all_signals. Its only user in the tree is drm_lock(), but it is exported too.
drm_lock is using block_all_signals to catch all the stop signals for a purpose that is not immediately clear to me.
Thanks, Roland
|  |