lkml.org 
[lkml]   [2008]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: Unify common parts of i8259.c
    Hi!

    > * Pavel Machek <pavel@suse.cz> wrote:
    >
    > > Merge common parts of i8259_{32,64} into i8259.c.
    >
    > hm, did you intend this to be a 'mechanic' (i.e. no functionality
    > changes expected) unification?

    Yes, it should have been mechanic, but I guess I was not careful
    enough.

    > We'd prefer to have 10 or 20 small commits instead one large commit -
    > because in -tip we can bisect any problems to the exact change that
    > caused it - while now we are left to guess about a rather large
    > change:

    I don't think I can split it into 20 changes, but I should be able to
    split it into 3 or so, and make them trivial enough to be bug
    free. (In fact, there were only about 20 lines of "real" changes in
    this, but it is impossible to see

    > 6 files changed, 347 insertions(+), 609 deletions(-)

    in this huge changelog). I'll produce better patches.

    Pavel

    --
    (english) http://www.livejournal.com/~pavelmachek
    (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


    \
     
     \ /
      Last update: 2008-05-21 00:37    [W:0.019 / U:119.816 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site