lkml.org 
[lkml]   [2008]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] block: blk_queue_bounce_limits can actually sleep
On Tue, 20 May 2008 21:58:57 +0200
> Yeah, THAT I agree with in genereal, but it's probably too much here
> since most callers will not block and probably do call it under the
> queue lock already (just guessing here, didn't audit any callers).
>
> > but it's all vague and waffly because Arjan forgot to tell us why
> > he's bothering to patch this code at all???
>
> Probably the math still isn't quite correct, so it ends up setting up
> the isa pool for no good reason :-(
>

well either it sleeps or it doesn't.....
if this guy should sleep (and right now it does) we shouldn't call it
from such contexts.
If we do the right thing and allocate the isa pools in a sane context,
it wouldn't ever sleep and the patch isn't needed...

\
 
 \ /
  Last update: 2008-05-20 23:05    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site