Messages in this thread |  | | | Date | Tue, 20 May 2008 13:02:34 +0200 | | From | Pau Oliva Fora <> | | Subject | Re: [PATCH] Add support for HTC Shift Touchscreen |
| |
Dmitry Torokhov wrote: > On Tue, May 20, 2008 at 01:08:44AM +0200, Pau Oliva Fora wrote: >> + >> +static int htcpen_open(struct input_dev *dev) >> +{ >> + outb_p(DEVICE_ENABLE, HTCPEN_PORT_INIT); >> + return 0; >> +} >> + >> +static void htcpen_close(struct input_dev *dev) >> +{ >> + free_irq(HTCPEN_IRQ, dev); >> +} >> + > > No, this will not work.. next time you open the device you won't have > IRQ anymore. You need the opposite of outb_p(DEVICE_ENABLE, > HTCPEN_PORT_INIT); here. >
It is actually working; it also works after suspend/resume without any issues.
I currently do not know a safe way of disabling the device, as HTC did not offer any specifications or datasheet when I requested, so everything in the driver has been reverse engineered.
Let me know if you think it's ok to leave it as is, otherwise I'll try to find the proper way to disable the device (it should not be much different than the way of enabling it). Best Regards,
Pau Oliva
|  |