Messages in this thread | | | Date | Fri, 02 May 2008 18:35:43 +0200 | From | Takashi Iwai <> | Subject | Re: patch driver-core-warn-about-duplicate-driver-names-on-the-same-bus.patch added to gregkh-2.6 tree |
| |
At Fri, 02 May 2008 20:22:23 +0400, Stas Sergeev wrote: > > Hello. > > Takashi Iwai wrote: > >> Another point is PM callbacks. Somehow > >> snd-pcsp will have to register them with > >> pcspkr. > > Hmm, isn't platform PM hook enough? > > pcspkr.c just sends an event at suspend or shutdown to the event > > handler. So, if the event was shut up at the beginning in the > > handler, nothing would be needed. > I don't think I understand what you mean... > Currently, pcspkr.c just stops the timer > counter to shut up the beep. > snd-pcsp needs more. snd_pcm_suspend_all() > for instance. Since it doesn't register > itself as a platform driver any more, he > have to register itself into pcspkr.c. > Or?
If snd-pcsp can hook up input pcspkr dynamically, you can (should) register snd-pcsp as a different name, as an individual platform driver. Then the whole PM stuff would still belong to snd-pcsp.
Takashi
| |