lkml.org 
[lkml]   [2008]   [May]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] fs: remove local variable copy of f_pos to enable thread-safe updates
On Fri, May 02, 2008 at 08:33:50AM -0700, Matti Linnanvuori wrote:

> File systems can be written so that implementations of read, lseek etc.
> acquire a lock before using *pos, which precludes races. That was the
> idea behind my patch. So, my patch does not necessarily cause races.
> read instances can be racy in Linux now because there is no lock to
> serialize read etc. system calls.

Oh, yes it does - current tree guarantees that variable passed to ->read()
will not change under it, so any code that relied on that got broken.

And no, modifying every driver's ->read() is not going to be fun - it's
not just filesystems.


\
 
 \ /
  Last update: 2008-05-02 17:43    [W:0.027 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site