Messages in this thread | | | Date | Fri, 2 May 2008 13:39:23 +0200 | From | Enrico Weigelt <> | Subject | Re: [PATCH] fix flags length in net 9p |
| |
* Steven Rostedt <rostedt@goodmis.org> wrote: > > Some files in the net/9p directory uses "int" for flags. This can > cause hard to find bugs on some architectures. This patch converts the > flags to use "long" instead.
IMHO it would be more consequent and clean to introduce an separate type for this and only use specific macros for manipulation. Of course this introduced some typing overhead, but enforces the coder to think more carefully about his code. For critical things like kernel stuff, I really prefer this way.
BTW: I just wondered a bit how the 9p driver finds out the numeric user ID's for 9P user names.
cu -- --------------------------------------------------------------------- Enrico Weigelt == metux IT service - http://www.metux.de/ --------------------------------------------------------------------- Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ ---------------------------------------------------------------------
| |