lkml.org 
[lkml]   [2008]   [May]   [19]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateMon, 19 May 2008 22:34:55 -0400
FromTheodore Tso <>
SubjectRe: [PATCH 4/4] ext4: call blkdev_issue_flush on fsync
On Fri, May 16, 2008 at 02:09:56PM -0500, Eric Sandeen wrote:
> To ensure that bits are truly on-disk after an fsync,
> we should call blkdev_issue_flush if barriers are supported.

This patch isn't necessary, and in fact will cause a double flush.
When you call fsync(), it calls ext4_force_commit(), and we do a the
equivalent of a blkdev_issue_flush() today (which is what happenes
when you do a submit_bh(WRITE_BARRIER, bh), which is what setting
set_ordered_mode(bh) ends up causing.

						- Ted


\
 
 \ /
  Last update: 2008-05-20 04:39    [from the cache]
©2003-2008