Messages in this thread | | | Subject | Re: [2.6 patch] asm-generic/int-ll64.h: always provide __{s,u}64 | From | Harvey Harrison <> | Date | Mon, 19 May 2008 15:27:28 -0700 |
| |
On Mon, 2008-05-19 at 15:01 -0700, H. Peter Anvin wrote: > Adrian Bunk wrote: > > Several compilers offer "long long" without claiming to support C99. > > > > Considering how frequent __s64/__u64 are used our userspace headers are > > anyway unusable without __s64/__u64 available. > > > > Always offer __s64/__u64 to non-gcc non-C99 compilers - if they provide > > "long long" that makes the headers compiling and if they don't they are > > anyway screwed. > > > > Signed-off-by: Adrian Bunk <bunk@kernel.org> > > This makes sense to me (I did, however, not want to make that change > part of the same changeset - one change at a time.) > > The main reason for not just blindly using "long long" has to do with > the use of gcc -ansi -pedantic in userspace, which is already taken care > of by the use of __extension__ in the __GNUC__ clause. >
If it is going to be unconditionally offered, we could get rid of __BYTEORDER_HAS_U64__ as a next step. Unless there is something I've missed.
Harvey
| |